Skip to content

DAOS-18400 vos: increase VOS_AGG_GAP_DEF to 30 seconds #17362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Nasf-Fan wants to merge 1 commit into from
Closed

DAOS-18400 vos: increase VOS_AGG_GAP_DEF to 30 seconds #17362

Nasf-Fan wants to merge 1 commit into from

Conversation

@Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Jan 10, 2026

Increase VOS_AGG_GAP_DEF from 20 seconds to 30 seconds to reduce the possibility of unexpected rejection for some slow transaction.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@Nasf-Fan
DAOS-18400 vos: increase VOS_AGG_GAP_DEF to 30 seconds
b0eaf65 
Increase VOS_AGG_GAP_DEF from 20 seconds to 30 seconds to reduce
the possibility of unexpected rejection for some slow transaction.

Signed-off-by: Fan Yong <[email protected]>
@github-actions
Copy link

github-actions bot commented Jan 10, 2026

Ticket title is 'daos_test/suite.py:DaosCoreTest.test_daos_distributed_tx - Failure assert_rc_equal src/tests/suite/daos_dist_tx.c:1493 DER_TX_RESTART(-2025) != DER_SUCCESS(0)'
Status is 'Open'
Labels: 'ci_master_daily,daily_test'
https://daosio.atlassian.net/browse/DAOS-18400

@Nasf-Fan Nasf-Fan marked this pull request as ready for review January 11, 2026 07:07
@Nasf-Fan Nasf-Fan requested review from a team as code owners January 11, 2026 07:07
@johannlombardi
Copy link
Contributor

johannlombardi commented Jan 12, 2026

@NiuYawei could you please review this one?

NiuYawei
NiuYawei requested changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@NiuYawei NiuYawei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in the ticket, I'm hesitate to increase this value based on a rare CI failure, which might be caused by an test environment issue. A blunt increase here risks premature ENOSPACE in production. (We've invested lots of fine-tuning work to prevent premature ENOSPACE, increasing this value would undo all those optimization)

@Nasf-Fan
Copy link
Contributor Author

Nasf-Fan commented Jan 13, 2026

More discussion with @Liang Zhen and @yawei Niu , it is afraid of the potential side-effect for space pressure because of increasing such update windows. For this CI test failure, it is quite possible caused by random network exception instead of DAOS logic bug. Let’s ignore it.

@Nasf-Fan Nasf-Fan closed this Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NiuYawei NiuYawei NiuYawei requested changes

@gnailzenh gnailzenh Awaiting requested review from gnailzenh

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nasf-Fan @johannlombardi @NiuYawei